Repository navigation
Potential fix for code scanning alert no. 17: Incomplete URL substring sanitization - #9
Merged
Merged
Conversation
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
KiidxAtlas
marked this pull request as ready for review
April 1, 2026 04:44
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/KiidxAtlas/python-hover/security/code-scanning/17
In general, to fix this kind of issue you must avoid substring checks on URLs or hostnames and instead perform exact or well-scoped comparisons against a whitelist of allowed hosts (or domains). For the Python docs, the canonical host is
docs.python.org, and we should only treat URLs from that exact host (optionally with thewww.prefix) as “Python docs”.Concretely, in
extension/src/ui/hoverPanel.ts, withingetDocHostLabel, we already normalize the hostname by stripping a leadingwww.. The best minimal fix is to replacehost.includes('docs.python.org')with a strict equality check: if the normalizedhostis exactly'docs.python.org', return'Python docs'; otherwise returnhostunchanged. This preserves existing behavior for legitimate Python docs URLs (whether they usehttps://docs.python.org/...orhttps://www.docs.python.org/...) while preventing other domains that merely contain that substring from being mis-labeled. No new methods or imports are required; we only change the conditional logic around that one line.Suggested fixes powered by Copilot Autofix. Review carefully before merging.